Improve the error message when pushing to a registry that does not support v2-2

[briandealwis]

Turns MANIFEST_INVALID / TAG_INVALID errors into slightly more helpful error messages:

Tried to push image manifest for localhost:5000/foo:bar but failed because: Registry does not support Image Manifest Version 2, Schema 2

Docker Registry 2.1, which returns a 400 / TAG_INVALID:

[ERROR] Failed to execute goal com.google.cloud.tools:jib-maven-plugin:0.9.11-SNAPSHOT:build (default-cli) on project first: Tried to push image manifest for localhost:5000/foo:bar but failed because: Registry does not support Image Manifest Version 2, Schema 2 | If this is a bug, please file an issue at https://github.com/GoogleContainerTools/jib/issues/new: 400 Bad Request
[ERROR] {"errors":[{"code":"TAG_INVALID","message":"manifest tag did not match URI"}]}
[ERROR] -> [Help 1]

Docker Registry 2.2, which returns a 400 / MANIFEST_INVALID:

[ERROR] Failed to execute goal com.google.cloud.tools:jib-maven-plugin:0.9.11-SNAPSHOT:build (default-cli) on project first: Tried to push image manifest for localhost:5000/foo:bar but failed because: Registry does not support Image Manifest Version 2, Schema 2 | If this is a bug, please file an issue at https://github.com/GoogleContainerTools/jib/issues/new: 400 Bad Request
[ERROR] {"errors":[{"code":"MANIFEST_INVALID","message":"manifest invalid","detail":{}}]}
[ERROR] -> [Help 1]

Pushing to quay.io, which returns a 415 / MANIFEST_INVALID (doesn't adhere to spec):

[ERROR] Failed to execute goal com.google.cloud.tools:jib-maven-plugin:0.9.11-SNAPSHOT:build (default-cli) on project first: Tried to push image manifest for quay.io/briandealwis/foo:popo but failed because: Registry does not support Image Manifest Version 2, Schema 2 | If this is a bug, please file an issue at https://github.com/GoogleContainerTools/jib/issues/new: 415 UNSUPPORTED MEDIA TYPE
[ERROR] {"errors":[{"code":"MANIFEST_INVALID","detail":{"message":"manifest schema version not supported"},"message":"manifest invalid"}]}
[ERROR] -> [Help 1]

Fixes #601

[chanseokoh]

Maybe we should just throw httpResponseException? The rationale is that, if we didn't have this extra parsing at all like before, it would have thrown httpResponseException.

[briandealwis]

Good catch. Will handle this in #937 as this is a lightly modified block taken from elsewhere.

[chanseokoh]

I noticed valueOf(String) will throw IllegalArgumentException if there is no matching enum, so I think we should catch that.

[briandealwis]

Good catch. Will handle this in #937 as this is a lightly modified block taken from elsewhere.

[chanseokoh]

I wonder if it's better to be a little bit less assertive with the claim, like "Registry may not be supporting ...". Just thinking TAG_INVALID might imply something different in some cases or there were genuinely other reasons (e.g., bugs) that produced an invalid manifest. WDYT?

[TadCordle]

Yeah, for example something like this would have been misleading for the artifactory errors, where the issue wasn't that they didn't support version 2 schema 2, the issue was that they were expecting fields we didn't provide.

[briandealwis]

Makes sense. Note that the original Artifactory error report seemed to be due to Artifactory not being configured to support v2-2 out of the box.

It's too bad the servers don't return any actionable information to identify the registry type. Docker Registry has the following headers:

{content-length=[79], content-type=[application/json; charset=utf-8], date=[Wed, 05 Sep 2018 18:12:25 GMT], docker-distribution-api-version=[registry/2.0], connection=[close]}

And quay.io has:

Headers: {content-length=[131], content-type=[application/json], date=[Wed, 05 Sep 2018 18:13:03 GMT], server=[nginx/1.14.0], connection=[keep-alive]}