Skip to content

Commit

Permalink
Fix permissions on cache when --no-push is set (#1445)
Browse files Browse the repository at this point in the history
  • Loading branch information
ejose19 authored Oct 2, 2020
1 parent 6c70f16 commit 0ef3a6b
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions pkg/executor/push.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,17 @@ var (
// CheckPushPermissions checks that the configured credentials can be used to
// push to every specified destination.
func CheckPushPermissions(opts *config.KanikoOptions) error {
var targets = opts.Destinations
// When no push is set, whe want to check permissions for the cache repo
// instead of the destinations
if opts.NoPush {
return nil
targets = []string{opts.CacheRepo}
}

checked := map[string]bool{}
_, err := fs.Stat(DockerConfLocation())
dockerConfNotExists := os.IsNotExist(err)
for _, destination := range opts.Destinations {
for _, destination := range targets {
destRef, err := name.NewTag(destination, name.WeakValidation)
if err != nil {
return errors.Wrap(err, "getting tag for destination")
Expand Down

0 comments on commit 0ef3a6b

Please sign in to comment.