Bugfix/trailing path separator (#1683)

* Test_EnvReplacement: env of path ends in a slash * Fix trailing path separator
GoogleContainerTools · Jul 8, 2021 · 682191f · 682191f
1 parent 1d9bc17
commit 682191f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/pkg/util/command_util.go b/pkg/util/command_util.go
@@ -79,9 +79,10 @@ func ResolveEnvironmentReplacement(value string, envs []string, isFilepath bool)
 	if err != nil {
 		return "", err
 	}
+	isDir := strings.HasSuffix(fp, pathSeparator)
 	fp = filepath.Clean(fp)
-	if IsDestDir(value) && !IsDestDir(fp) {
-		fp = fp + "/"
+	if isDir && !strings.HasSuffix(fp, pathSeparator) {
+		fp = fp + pathSeparator
 	}
 	return fp, nil
 }

diff --git a/pkg/util/command_util_test.go b/pkg/util/command_util_test.go
@@ -53,6 +53,14 @@ var testEnvReplacement = []struct {
 		isFilepath:   true,
 		expectedPath: "/simple/path/",
 	},
+	{
+		path: "$simple",
+		envs: []string{
+			"simple=/path/",
+		},
+		isFilepath:   true,
+		expectedPath: "/path/",
+	},
 	{
 		path: "${a}/b",
 		envs: []string{