-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if registry mirror does not have it, can you default it to index.docker.io #1473
Comments
Yes Kaniko has what (I would consider) breaking behaviour compared to Docker!!
With this odd re-interpretation of Given the increased usage of mirrors (and in all other tools I am aware of it, registry mirror is a pull through like Docker daemon) I would like to see this as the top priority for a fix! |
Fixes GoogleContainerTools#1473 The initial implementation of the registry mirror only allowed a single mirror, and if pulling from the mirror failed, the build would fail. This change introduce: - multiple registry mirrors instead of a single one - fallback if an image can't be pulled from a registry This is the same behaviour as the docker daemon, and will allow to use a registry mirror such as `mirror.gcr.io` which is incomplete, and doesn't have all the content that the default registry on docker.io has. Note that there are no changes in the CLI flags, the `--registry-mirror` flag is still valid. But now it can be used multiple times to setup more than one registry mirror.
Fixes GoogleContainerTools#1473 The initial implementation of the registry mirror only allowed a single mirror, and if pulling from the mirror failed, the build would fail. This change introduces: - multiple registry mirrors instead of a single one - fallback if an image can't be pulled from a registry This is the same behavior as the docker daemon and will allow using a registry mirror such as `mirror.gcr.io` which is incomplete and doesn't have all the content that the default registry on docker.io has. Note that there are no changes in the CLI flags, the `--registry-mirror` flag is still valid. But now it can be used multiple times to set up more than one registry mirror.
I have the same problem. I need multiples registry mirrors or at least, when my private registry is not available, the execution of kaniko can continue and does not fail. |
there is a PR ready at #1498 which is just waiting for review... if you really need it, you can build it locally and push it to your own registry. We've been using it for all our builds and it works nicely. |
I really appreciate your PR. Although the option you are telling me helps me, I prefer to wait for it to be reviewed and officially implemented. |
Fixes #1473 The initial implementation of the registry mirror only allowed a single mirror, and if pulling from the mirror failed, the build would fail. This change introduces: - multiple registry mirrors instead of a single one - fallback if an image can't be pulled from a registry This is the same behavior as the docker daemon and will allow using a registry mirror such as `mirror.gcr.io` which is incomplete and doesn't have all the content that the default registry on docker.io has. Note that there are no changes in the CLI flags, the `--registry-mirror` flag is still valid. But now it can be used multiple times to set up more than one registry mirror. Co-authored-by: Tejal Desai <tejaldesai@google.com>
This is more of a question. Right now Kaniko allows you to specify a registry mirror --registry-mirror. Is it possible to have it look at the registry mirror first and if it's not there than pull from the default
index.docker.io
. In other words, support multiple registry mirrors.The main desire for this is that dockerhub is limiting API calls to 100 per 6 hours. We wanted to utilize google's mirror container registry. However, if it does not contain the image kaniko will fail. Google doesn't copy the image to the mirror right away and it will remove unused mirrors if it's not referenced
--cache
flagThe text was updated successfully, but these errors were encountered: