-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation of whitelist-var-run in 1.7.0 does not work #1795
Comments
Can we have test cases for prospective parameter deprecations, to avoid build failures? |
Can confirm However, when using
|
Any news or fix on this? I see exactly the same output as @hashworks. |
Does the fix in #1339 address the issue? Perhaps we should just fix that up and merge it before v1.8.0. |
I'm not that familiar with Golang and especially the codebase of this project, yet, but I could try to fix this. |
@imjasonh Well, I figured it out and provided a fix. |
Actual behavior
Using
--whitelist-var-run
in 1.7.0 results inError: unknown flag: --whitelist-var-run
, crashing the build.Using the replacement
--ignore-var-run
results inFlag --ignore-var-run has been deprecated, please use ignore-var-run instead.
Expected behavior
Using
--whitelist-var-run
in 1.7.0 results in a deprecation warning and automatically assumes--ignore-var-run
, not breaking the build.Using the replacement
--ignore-var-run
does not produce a deprecation warning.To Reproduce
Additional Information
The text was updated successfully, but these errors were encountered: