-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove build args from composite key and replace all build args #1085
remove build args from composite key and replace all build args #1085
Conversation
…e adding command to the cache
… into rm_buildargs_from_cache_key
Would you mind expanding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions and more tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answering comments
4bf24ed
to
b9f4c4b
Compare
@cvgw Please take another look! |
Fixes #1008
Description
In this change, we remove all the
build-args
being added to composite key.With
--cache
flag true, kaniko will try to optimize the builds. It will execute all the metadata command like "ENV", "ARG" and update theconfig.Env
to find dependencies between stage.It discards the updated config changes after the optimize phase.
In this PR, I added a change
This will ensure, only layers which actually use the
ARG
will change ifARG
value changes.Added tests for the same.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.