-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split travis integration tests #1090
Merged
tejal29
merged 1 commit into
GoogleContainerTools:master
from
cvgw:u/cgwippern/1089-split-integration-tests
Mar 4, 2020
Merged
Split travis integration tests #1090
tejal29
merged 1 commit into
GoogleContainerTools:master
from
cvgw:u/cgwippern/1089-split-integration-tests
Mar 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvgw
force-pushed
the
u/cgwippern/1089-split-integration-tests
branch
11 times, most recently
from
March 1, 2020 05:18
58a20ed
to
3f38983
Compare
samos123
reviewed
Mar 2, 2020
samos123
reviewed
Mar 2, 2020
samos123
reviewed
Mar 2, 2020
samos123
reviewed
Mar 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change itself is good, but seems 2 PRs got mixed together
This pr depends on the other pr that you are referring to. The intention is
that this Pr would be reviewed and merged after the other one has been
completed.
…On Sun, Mar 1, 2020, 6:02 PM Sam Stoelinga ***@***.***> wrote:
***@***.**** commented on this pull request.
Change itself is good, but seems 2 PRs got mixed together
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1090?email_source=notifications&email_token=ABRSFSLQD4D66IQWWNPFAYDRFMHSZA5CNFSM4K67JEVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXPLESQ#pullrequestreview-366916170>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRSFSMJ6DZZQ23X4CH4HM3RFMHSZANCNFSM4K67JEVA>
.
|
Split integration tests into three travis jobs and move image building to it's own stage. TestRun and TestLayers each have their own job while the rest of the integration tests run in a single job
cvgw
force-pushed
the
u/cgwippern/1089-split-integration-tests
branch
from
March 3, 2020 19:52
3f38983
to
101ba22
Compare
tejal29
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1089
Description
Split integration tests into three travis jobs and move image building to it's own stage.
TestRun and TestLayers each have their own job while the rest of the integration tests run in a single job
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes