-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 64 busybox #1254
add 64 busybox #1254
Conversation
TODO run container diff on tis debug image and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current busybox v is 1.31.1
https://hub.docker.com/_/busybox
https://busybox.net/
deploy/Dockerfile_debug
Outdated
@@ -46,6 +46,9 @@ COPY --from=0 /usr/local/bin/docker-credential-gcr /kaniko/docker-credential-gcr | |||
COPY --from=0 /go/src/github.com/awslabs/amazon-ecr-credential-helper/bin/linux-amd64/docker-credential-ecr-login /kaniko/docker-credential-ecr-login | |||
COPY --from=0 /usr/local/bin/docker-credential-acr-linux /kaniko/docker-credential-acr | |||
COPY --from=1 /distroless/bazel-bin/experimental/busybox/busybox/ /busybox/ | |||
# Workaround See #https://github.com/GoogleContainerTools/kaniko/issues/656#issuecomment-564035645 | |||
COPY --from=amd64/busybox:1.31.0 /bin/busybox /busybox/busybox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why busybox 1.31.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can definitely pick up the latest version.
Will update it. Thanks for bringing that to my attention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is solved now 👍
Related #1277 |
deploy/Dockerfile_debug
Outdated
WORKDIR /distroless | ||
RUN bazel build //experimental/busybox:busybox_tar | ||
RUN tar -C /distroless/bazel-bin/experimental/busybox/ -xf /distroless/bazel-bin/experimental/busybox/busybox.tar | ||
|
||
FROM scratch | ||
COPY --from=0 /go/src/github.com/GoogleContainerTools/kaniko/out/* /kaniko/ | ||
COPY --from=0 /usr/local/bin/docker-credential-gcr /kaniko/docker-credential-gcr | ||
COPY --from=0 /go/src/github.com/awslabs/amazon-ecr-credential-helper/bin/linux-amd64/docker-credential-ecr-login /kaniko/docker-credential-ecr-login | ||
COPY --from=0 /usr/local/bin/docker-credential-acr-linux /kaniko/docker-credential-acr | ||
COPY --from=1 /distroless/bazel-bin/experimental/busybox/busybox/ /busybox/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no more needed
@alex1989hu Thans you so much for running the container-diff.
|
Verified by @alex1989hu here https://pastebin.com/1z8uWRpk |
FROM scratch | ||
COPY --from=0 /go/src/github.com/GoogleContainerTools/kaniko/out/* /kaniko/ | ||
COPY --from=0 /usr/local/bin/docker-credential-gcr /kaniko/docker-credential-gcr | ||
COPY --from=0 /go/src/github.com/awslabs/amazon-ecr-credential-helper/bin/linux-amd64/docker-credential-ecr-login /kaniko/docker-credential-ecr-login | ||
COPY --from=0 /usr/local/bin/docker-credential-acr-linux /kaniko/docker-credential-acr | ||
COPY --from=1 /distroless/bazel-bin/experimental/busybox/busybox/ /busybox/ | ||
COPY --from=amd64/busybox:1.31.1 /bin /busybox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line should be the first COPY in this stage to achieve a bit more optimized builds.
Trying to
Fixes #656
Copying the /busybox/busybox from amb46/busybox to see if this issue is solved.