Move snapshotPathPrefix into a method #1359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the value to be determined on the fly, which supports consumers that use Kaniko snaphot as a library and may need to change the value of
config.KanikoDir
Description
The Snapshotter path prefix when invoking
TakeSnapshotFS()
is uses a local variable that can be overridden in tests. But this prevents the invoker of theTakeSnapshotFS()
func from redefining theconfig.KanikoDir
. By moving thesnapshotPathPrefix
into agetSnapshotPathPrefix()
func, the value is resolved just-in-time, which allows the value to be configured again.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes