Fix .dockerignore for build context copies in later stages #1447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.dockerignore currently isn't being applied to build context copies during later (non-first) stages.
E.g.
This PR adjusts the .dockerignore integration test to surface the issue and fixes it by refactoring the excluded file handling.
Instead of setting more global state, this replaces it with a
FileContext
struct (containing a root and excluded files), and passes that from the build start down to all relevant commands / functions.A
COPY --from
then simply overwrites the FileContext without any excluded files. The handling aroundIsFirstStage
is no longer necessary.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Doesn't seem necessary.
Well, a modification really.
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.