-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding multiarch image support #1474
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
68d8732
to
ef4ec7c
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@bahetiamit can you please sign the cla? |
@tejal29 I have initiated corporate CLA request and soon will sign this PR. |
@googlebot I signed it! |
Thanks a lot @bahetiamit. Not an github workflow expert. Will give it a try! |
@tejal29 Did you get a chance to look at this? |
@tejal29 Reminder, get to this on Friday morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this PR and sorry for the delay.
Can you make the same changes to deploy/Dockerfile_debug and deploy/Dockerfile_warmer.
Also, i am more comfortable with gcloud
flow.
Can you make the changes to cloudbuild.yaml
, cloudbuild_release.yaml
?
@@ -0,0 +1,32 @@ | |||
diff --git a/build/build-config-edit.sh b/build/build-config-edit.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this added by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch is required as https://github.com/Azure/acr-docker-credential-helper is hard coded to build for amd64.
@bahetiamit ping. would you able to pick this up? Thanks |
Sure. I will work on this. |
@tejal29 This might be a dumb question, but if you are installing |
@darewreck54, we need docker to build an image to run the test. |
This PR tries to address #1462 by adding multi architecture support to kaniko image.
Description
It uses github actions & buildx & QEMU to build and publish multi-arch kaniko executor image. This adds the flexibility & makes it easy to add support for other architectures. Few dependencies in image are now built from source as binaries are not readily available.
Github workflow is created to execute on a new version release. Once a new github release is done, this workflow automatically kicks in and publishes the image.
Validations
I was able to publish images to my docker hub repo - https://hub.docker.com/repository/docker/bahetiamit/executor/tags?page=1 as I don't have access to gcr.io. Github workflow in action for this - https://github.com/bahetiamit/kaniko/runs/1330719714?check_suite_focus=true
I have made the changes to workflow for gcr.io by referring to https://medium.com/mistergreen-engineering/uploading-a-docker-image-to-gcr-using-github-actions-92e1cdf14811. Someone needs to test this. Also this workflow needs a repository secret GCR_DEVOPS_SERVICE_ACCOUNT_KEY to be able to push the images to gcr.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes