Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pax tar format #1809

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Conversation

twavv
Copy link
Contributor

@twavv twavv commented Oct 29, 2021

Fixes #1808.

Description

Use PAX tar format to accurately encode mtimes.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Oct 29, 2021
@imjasonh imjasonh merged commit ee95be1 into GoogleContainerTools:master Dec 23, 2021
gcalmettes pushed a commit to gcalmettes/kaniko that referenced this pull request Dec 24, 2021
* Use PAX tar format

* Add test case
@twavv twavv deleted the use-pax-tar-format branch December 26, 2021 01:53
angusjfw added a commit to pi-top/kaniko that referenced this pull request Dec 14, 2022
angusjfw added a commit to pi-top/kaniko that referenced this pull request Dec 14, 2022
This reverts commit ee95be1.
Due issues with reproducible builds: GoogleContainerTools#2005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kaniko produces images with all mtimes rounded to the nearest second
2 participants