-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme insecure flags #1811
Update readme insecure flags #1811
Conversation
Referring to --skip-tls-verify-registry as a "flag" is misleading since command line flags usually require no value. Thus, the documentation is updated to match the behavior of the command line argument.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Referring to --insecure-registry as a "flag" is misleading since command line flags usually require no value. Thus, the documentation is updated to match the behavior of the command line argument.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
* Clarify usage of --skip-tls-verify-registry argument Referring to --skip-tls-verify-registry as a "flag" is misleading since command line flags usually require no value. Thus, the documentation is updated to match the behavior of the command line argument. * Clarify usage of --insecure-registry argument Referring to --insecure-registry as a "flag" is misleading since command line flags usually require no value. Thus, the documentation is updated to match the behavior of the command line argument.
Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)
Description
Clarifies the usage of --insecure-registry and --skip-tls-verify-registry command line
arguments. They were being referred to as flags, which mislead my into believing they
did not require a value. This PR updates the ReadMe to be a bit more clear.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.