Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The K8s e2e test has been failing since the move to actions. This adds a bunch of instrumentation I used to track down the failure. The biggest change was trying to consolidate test output to go through
t.Log
so that the logs are properly correlated. I disabled-v
because I find the resulting interleaving to be incredibly difficult to parse the failures out of.The crux of the issue was that the kaniko images were in ErrImgPull because the registry wasn't visible to the cluster. This was fixed by migrating to the minikube registry addon, but the next problem was that hostPath wasn't working properly with the
--driver=docker
. So I migrated back to what was being successfully used on Travis and 🎉 things pass.The main "fix" was a few parts:
registry:2
,Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes