Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setup-gcloud@v0.3.0 instead of @master #1854

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Dec 22, 2021

Shouldn't be referring to workflow actions from a moving source, for security and stability.

see google-github-actions/setup-gcloud#451

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@sethvargo
Copy link

@imjasonh we reverted the branch rename for now, but this is a good change. I'd recommend pinning to @v0 if you want to avoid needing to upgrade to specific versions. Pinning to a specific version is best for security though.

@imjasonh
Copy link
Collaborator Author

@imjasonh we reverted the branch rename for now, but this is a good change. I'd recommend pinning to @v0 if you want to avoid needing to upgrade to specific versions. Pinning to a specific version is best for security though.

Yep, this never should have been @master. 👍

@imjasonh imjasonh merged commit 17f5e55 into GoogleContainerTools:master Dec 23, 2021
gcalmettes pushed a commit to gcalmettes/kaniko that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants