Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in snapshotting #214

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Conversation

priyawadhwa
Copy link
Collaborator

When comparing layers in #204, the test for WORKDIR was failing because kaniko had an extra layer (It was creating an extra layer for the WORKDIR / command). I found two bugs when looking into it:

  1. When snapshotting specific files, kaniko wasn't snapshotting the root directory, so when we ran WORKDIR / it appended a new layer even though nothing had changed.
  2. when resolving env replacement kaniko was adding an extra backslash so / became //

This should fix both those bugs

@priyawadhwa priyawadhwa merged commit 9ad8647 into GoogleContainerTools:master Jun 21, 2018
@priyawadhwa priyawadhwa deleted the bug branch June 21, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants