(fix):Pass full URI path to bucket.GetNameAndFilepathFromURI
#2221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2200
Description
On version 1.9.0 context fetch from S3 is broken due to
url.Parse
requiring full path:kaniko/pkg/util/bucket/bucket_util.go
Line 77 in 90e426b
Currently when we do
--context=s3://my-bucket/my-path/context.tar.gz
we would pass onlymy-bucket/my-path/context.tar.gz
which breaks context fetch. Tested with S3 but #2200 refersgs://
so passing srcContext for both cases.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.