Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue where warmer CLI always validated optional arg -> breakage for majority of users #2603

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

aaron-prindle
Copy link
Collaborator

@aaron-prindle aaron-prindle commented Jun 28, 2023

fixes #2602

Resolves bug in PR #2499 in which the Dockerfile path is always set by default (and thus never empty - "") as well as always validated even when the --dockerfile flag is not supplied -> validation error which breaks normal usage of passing --image flag only.

@RoSk0
Copy link

RoSk0 commented Jun 29, 2023

I'm not really familiar with Go , but this looks correct to me. I was suspecting that the default value was in charge of the mess , but I see the validation improved as well. So 👍 from me.

Copy link
Contributor

@chuangw6 chuangw6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aaron-prindle for the fix!!

@chuangw6 chuangw6 merged commit 974c494 into GoogleContainerTools:main Jun 29, 2023
kylecarbs pushed a commit to coder/kaniko that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warmer behaviour changed in the 1.12.0 release breaking pipelines
3 participants