-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid returning the UID when resolving the GIDs. #2689
Conversation
@gadiego92 thanks for the PR here! Currently it seems the unit tests are failing w/ this PR: log snippet:
|
Thank you for your investigation here @gadiego92, adding some of the information you sent me inline into the comment for visibility/context:
In doing my own investigation into
Additionally, it seems the
From this, I believe that the
|
bb79911
to
110ff46
Compare
cf3bb64
to
41fe12a
Compare
@aaron-prindle the main issue (#2327) is fixed. I mean when you use the following Dockerfile: Kaniko @ head as you already mentioned fails to run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gadiego92 thanks for your investigation and PR here! LGTM!
Fixes #2327
Description
Avoid returning the UID when resolving the GIDs.
It looks like Kaniko @ head by default returns the UID as a GID.
When it tries to resolve the GIDs it cannot find the UID in the group list because indeed it could be it is not a GID.
Reviewer Notes