Set default home value #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyawadhwa
force-pushed
the
home
branch
3 times, most recently
from
47052ee
to
0886079
Compare
dlorenc
reviewed
Aug 10, 2018
pkg/commands/run.go
Outdated
| for _, env := range envs { | ||
| split := strings.SplitN(env, "=", 2) | ||
| if split[0] == constants.HOME { | ||
| return envs |
There was a problem hiding this comment.
This seems like it can only set the default HOME, as designed. Maybe rename the function, or refactor it to support more default values in the future?
|
missed a spot: |
dlorenc
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this documentation it looks like the default value of home is set based on the user.
From some experimentation it looks like if the USER is root we set the default value to /root, and if USER is set then the default value of HOME is /home/${user}
Should fix #280