Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skip tls flag for private git context #2854

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

schwannden
Copy link
Contributor

@schwannden schwannden commented Nov 15, 2023

Description

If git clone context is a private self-signed repository, we allow user to add --git insecure-skip-tls=true flag in the option. The value is default to false, this behavior is in accordance with the go-git package.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

- kaniko adds a new flag `--git insecure-skip-tls` to support private git context

Copy link

google-cla bot commented Nov 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

README.md Outdated Show resolved Hide resolved
@aaron-prindle
Copy link
Collaborator

@schwannden can you rebase, there was an issue @ HEAD that was recently fixed (this should resolve the test error you are seeing)

If git clone context is a private self-signed repository, we allow user
to add --git insecure-skip-tls=true flag in the option. The value is
default to false, this behavior is in accordance with the go-git
package.
@schwannden
Copy link
Contributor Author

@schwannden can you rebase, there was an issue @ HEAD that was recently fixed (this should resolve the test error you are seeing)

@aaron-prindle done

@schwannden schwannden closed this Nov 30, 2023
@schwannden schwannden reopened this Nov 30, 2023
@schwannden
Copy link
Contributor Author

@JeromeJu any update?

Copy link
Collaborator

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR here @schwannden!

@aaron-prindle aaron-prindle merged commit 20a6ab5 into GoogleContainerTools:main Feb 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants