Bump docker dependency and fix import. #2916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
added a commit
to dlorenc/os
that referenced
this pull request
Dec 19, 2023
I sent this upstream at GoogleContainerTools/kaniko#2916 Signed-off-by: Dan Lorenc <dlorenc@chainguard.dev>
This was a deprecated package in docker that moved to moby. Fix the import and bump the dep. Signed-off-by: Dan Lorenc <dlorenc@chainguard.dev>
dlorenc
added a commit
to dlorenc/os
that referenced
this pull request
Dec 19, 2023
I sent this upstream at GoogleContainerTools/kaniko#2916 Signed-off-by: Dan Lorenc <dlorenc@chainguard.dev>
imjasonh
approved these changes
Dec 19, 2023
|
#2910 also bumps the docker dependency: so am thinking this PR might no longer be necessary. |
|
Closing this as this should be fixed by #2910. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a deprecated package in docker that moved to moby. Fix the import and bump the dep.
Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)
Description
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes