Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor command line arguments and the executor #306

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Refactor command line arguments and the executor #306

merged 2 commits into from
Aug 23, 2018

Commits on Aug 23, 2018

  1. Refactor command line arguments and the executor 

    In this refactor I:

1. Created KanikoOptions to make it easier to pass around arguments
passed in through the command line
2. Reorganized executor.go by putting the logic for pushing the image in
a new file push.go
3. Made some error messages clearer
4. Fixed a mistake in the README for pushing to AWS
5. Marked the --bucket flag as hidden since we want people to use
--context instead, and marked an aws flag as hidden which is set in a
vendored directorya
    Priya Wadhwa committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    cfa822f View commit details
    Browse the repository at this point in the history

  2. Review code comments; improved error messages for push

    Priya Wadhwa committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    d867ead View commit details
    Browse the repository at this point in the history