Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document env var lookup for --build-arg #3353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devfbe
Copy link

@devfbe devfbe commented Oct 29, 2024

Add more documentation for the --build-arg parameter of the executor. Describe that it's possible to lookup build argument values from the environment and that this might be useful if you don't want to fiddle around with shell escaping.

Description

Just improved the README section of the --build-arg parameter. I exactly needed the feature that you can lookup build arg values from the environment by just passing the build arg key. I only figured out that this is already possible because I red the source code - so I thought it's worth mentioning it in the documentation.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Improved --build-arg parameter documentation

Add more documentation for the --build-arg parameter of the executor.
Describe that it's possible to lookup build argument values from the
environment and that this might be useful if you don't want to fiddle
around with shell escaping.
Copy link

google-cla bot commented Oct 29, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@devfbe
Copy link
Author

devfbe commented Nov 24, 2024

(CLA signed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant