Include source stage cache key in cache key for COPY commands using --from #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvgw
force-pushed
the
u/cvgw/include_source_stage_digest_in_cache_key_copy_from_commands
branch
4 times, most recently
from
042771f
to
eace4e7
Compare
cvgw
changed the title
cvgw
force-pushed
the
u/cvgw/include_source_stage_digest_in_cache_key_copy_from_commands
branch
3 times, most recently
from
69c8794
to
6b88c13
Compare
cvgw
force-pushed
the
u/cvgw/include_source_stage_digest_in_cache_key_copy_from_commands
branch
3 times, most recently
from
36200a8
to
a8bfba2
Compare
cvgw
changed the title
|
This PR also requires #899 to be fixed in order to completely address the issue |
tejal29
approved these changes
Dec 9, 2019
cvgw
force-pushed
the
u/cvgw/include_source_stage_digest_in_cache_key_copy_from_commands
branch
from
a8bfba2
to
58919ba
Compare
Include the digest of the stage specified in the --from argument for COPY commands which use --from
cvgw
force-pushed
the
u/cvgw/include_source_stage_digest_in_cache_key_copy_from_commands
branch
2 times, most recently
from
561db28
to
db76b60
Compare
* use the cachekey of the src stage rather than the digest for COPY --from commands as they are reproducible unlike digests * track digest to cache keys and stage indexes to digest * add extra debug logging for troubleshooting cachekey building issues * convert Sha256 hashes to hex encoded strings rather than plain strings for easier human reading
cvgw
force-pushed
the
u/cvgw/include_source_stage_digest_in_cache_key_copy_from_commands
branch
from
db76b60
to
b19214a
Compare
cvgw
deleted the
u/cvgw/include_source_stage_digest_in_cache_key_copy_from_commands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address one part of the issue in #870
Description
Include the source stage cache key in the cache key for COPY commands which use --from. This will insure when the source stage for the COPY command changes the cache for said COPY command is invalidated.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.