Add example otel-collector configurations #1152
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| # Available Configurations | ||
|
|
||
| _otel-collector-monarch.yaml_: Serves as a template for exporting metrics |
There was a problem hiding this comment.
suggest bold instead of underline. underline usually implies a link.
There was a problem hiding this comment.
Or even inline code maybe?
There was a problem hiding this comment.
This format is italic, not underline.
There was a problem hiding this comment.
Which is the usual format when quoting a book name or doc name? I assume.
| # Instructions | ||
|
|
||
| * **Apply ConfigMap**: Apply the desired ConfigMap to your cluster. | ||
| * **Restart otel-collector**: The otel-collector deployment should restart automatically. If it doesn't, execute: |
There was a problem hiding this comment.
How does it know to restart?
There was a problem hiding this comment.
The controller looks for a change in annotation and restarts the pod.
| @@ -0,0 +1,152 @@ | |||
| # Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
How will we know to update these when we change the gcloud template? Is there any way we can have a linter that produces this from that and then verify it matches without drift?
There was a problem hiding this comment.
I'd prefer we migrate away from the manual templating asap before implementing too much scripts, i.e. having API for monitoring configuration and filtering. These samples exist as a intermediate solution.
tiffanny29631
force-pushed
the
monarch-sample
branch
from
5b2808b to
3e2ace2
Compare
| // | ||
| // - workload identity: | ||
| // - e2e-test-metric-writer GSA with roles/monitoring.metricWriter IAM | ||
| // - roles/iam.workloadIdentityUser on config-management-monitoring/default for e2e-test-metric-writer |
There was a problem hiding this comment.
We don't need this anymore with BYOID, right?
There was a problem hiding this comment.
Good catch. Tweaking the setup now, the tests are passing on failure scenarios, still working on it.
| it := listMetricInGCM(ctx, nt, client, startTime, descriptor) | ||
| if includGCM { | ||
| return validateMetricInGCM(nt, it, descriptor, nt.ClusterName) | ||
| } |
There was a problem hiding this comment.
e2e/testcases/otel_collector_test.go:318:6: SA4004: the surrounding loop is unconditionally terminated (staticcheck)
return nil
^
3e2ace2 to
7dff4c0
Compare
|
@tiffanny29631: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.