test: Only check declared_resources metric #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest-required |
The fix GoogleContainerTools#1232 only affects declared_resources from Config Sync. The metric from RG controller may take longer to be ready. Skip checking for those target values for now.
tiffanny29631
force-pushed
the
resource-metric
branch
from
a8608c3 to
728d633
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit fc90403
into
GoogleContainerTools:main
6 checks passed
tiffanny29631
added a commit
to tiffanny29631/kpt-config-sync
that referenced
this pull request
Jun 12, 2024
The fix GoogleContainerTools#1232 only affects declared_resources from Config Sync. The metric from RG controller may take longer to be ready. Skip checking for those target values for now.
google-oss-prow bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
…ix (#1232) (#1254) * [metric] #3 Reset declared_resource to 0 when commit updates (#1232) The current OpenCensus library keeps a metric stream that is uniquely identified by commit alive even though no new values are issued. This makes the Otel Collector metricstransform processor receives all time value when calculating the max and gives false output. The temporary work around is to reset the stream of previous commit to 0 when parser sees new commit. b/321875474 * Use default timeout for metric value check (#1264) * test: Only check declared_resources metric (#1268) The fix #1232 only affects declared_resources from Config Sync. The metric from RG controller may take longer to be ready. Skip checking for those target values for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix #1232 only affects declared_resources from Config Sync.
The metric from RG controller may take longer to be ready. Skip checking for those target values for now.