-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve documentation #109
base: main
Are you sure you want to change the base?
docs: improve documentation #109
Conversation
@thesayyn there seems to be some checks awaiting approval :-? Can you approve them so they run? Thanks!! |
@thesayyn the failures I get in those checks match the weird failure I got while trying to generate the docs and why I added the I'm not sure what's going on, It seems to only be failing in |
OK, I've dug a bit into this and I think the issue is that, somehow (still have to check why) I needed to add Now, here's the thing, But, once I remove it again and re-run the tests for Bazel
And sure enough, when I check, that was added in bazelbuild/bazel@3575211 so again, very modern Bazel. Yet, And look what I found 😄 bazel-contrib/bazel-lib#975 and bazel-contrib/bazel-lib#976 So, I'm going to try and use |
OK, so there's something very weird going on when trying to make this work with I'm happy to make a PR bumping the CI to Can you let me know? I'd really like to unblock and land this so I can rebase the rest of the PRs. Thanks!! |
d736371
to
f5cce80
Compare
27242f4 pushed lock version to `12` (my guess is Bazel 8?) plus other changes that e.g. don't match running with `.bazelversion`'s `7.3.1`. Regardless, the `MODULE.bazel.lock` file is still not stable and e.g. just running it in another operating system causes things to change... so let's just ignore it like I did for the `e2e` tests in 70c14c0
Revamp README adding an improved version of the Bzlmod and `WORKSPACE` snippets that are available in the release page. IMHO the release page should now remove those snippets and point to the README.
f5cce80
to
886310a
Compare
@thesayyn I've rebased the PR removing the changes to Also, could you approve the CI run? Thanks!! |
Split the Bzlmod / `WORKSPACE` docs from `apt.install` macro and remove a bunch of old references. Also mark it all as legacy since the present and future is all Bzlmod. Create apt/extensions docs. Add a whole common section to both docs with (hopefully :) easy-to-follow documentation inspired by my answer to a Slack question (https://bazelbuild.slack.com/archives/CA3NW13MH/p1729804678924819).
886310a
to
9b42e2f
Compare
Revamp README adding an improved version of the Bzlmod and
WORKSPACE
snippets that are available in the release page. IMHO the release page should now remove those snippets and point to the README.Split the Bzlmod /
WORKSPACE
docs fromdeb_index
and remove a bunch of old references. Also mark it all as legacy since the present and future is all Bzlmod.Create apt/extensions docs.
Add a whole common section to both docs with (hopefully :) easy-to-follow documentation inspired by my answer to a Slack question.
It's probably best and easiest to check the rendered markdown in my branch:
Both are very similar since I've copy-pasted the common part of the doc. I tried refactoring part of the doc to reuse it in both places but I couldn't use a template replacement in the
apt.install
macro docstring.NOTE: I had to
updateaddaspect_bazel_lib
andbazel_skylib
pluscache.bzl
as a dependency inapt/private/BUILD.bzl
to getbazel run //docs:update
to work.