Fix for packages sharing the same dependencies #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the first package in bullseye.yaml would have the dependencies listed as part of the package dependencies
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@jacobshirley we require a signed CLA before proceeding |
thesayyn
approved these changes
Apr 16, 2024
|
Sure, that's done now |
thesayyn
reviewed
Apr 16, 2024
thesayyn
reviewed
Apr 16, 2024
thesayyn
reviewed
Apr 16, 2024
|
Also buildifier is failing. |
|
Apologies for the delay on this. Thank you for your feedback. Hopefully that's looking ok now |
thesayyn
approved these changes
Apr 30, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I was running into issues where, if multiple packages depend on the same packages, only the first one in the list will receive them. By removing the performance code in the resolver, it appears to be fixed. I've added a test, which verifies the nginx has a module that is required by both 'nginx-full' and 'nginx-core', when only 'nginx-core' goes into the image.
Please feel free to close this PR and do a better fix if there is one.