fix package :data visibility so it's compatible with cacerts()
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The I'm not sure if this is a byproduct of another change and the lock file never got regenerated, or maybe my environment is somehow creeping in? |
|
Yeah, we should be ignoring the lockfiles from formatter. Feel free to revert those lockfile changes. |
|
@thesayyn lockfile is reverted ... though it'll have a legit change if you re-gen it b/c I added a package |
|
that's true, sorry, you can regen it. |
regenned the lockfile and rebased on oddly, the spurious whitespace diff I was seeing before is no longer occurring 🤷 |
thesayyn
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set package
:datavisibility to public so it can be used in a call tocacerts()I stuck a quick check into
examples/apttests to verify that it behaves as expected.