tar: Make all gzip compression hermetic #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hm, I thought that the aspect build tar would support this universally? |
DolceTriade
force-pushed
the
hermetictar
branch
from
6cf2d86
to
08cf7ce
Compare
We weren't passing the flag to make gzip hermetic. Without the flag to ignore timestamp, the shasum will differ based on the system time. Also, DEFAULT_ARGS contained "--options=gzip:...", which is invalid when using any other compression scheme. Therefore, remove that option from DEFAULT_ARGS and provide an alternate function called `add_default_compression_args` to add per-compression type default arguments which can do things like make the compression more hermetic.
DolceTriade
force-pushed
the
hermetictar
branch
from
08cf7ce
to
3e3b5ed
Compare
DolceTriade
changed the title
|
Ok, tests pass now. While running I realized a lot more than flatten was not hermetic, so I fixed those as well. Please let me know if you'd like a different approach. I also updated the commit message with the motivations. |
|
I'd love to get this merged, I'm also using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't passing the flag to make gzip hermetic. Without the flag to
ignore timestamp, the shasum will differ based on the system time.
Also, DEFAULT_ARGS contained "--options=gzip:...", which is invalid when
using any other compression scheme. Therefore, remove that option from
DEFAULT_ARGS and provide an alternate function called
add_default_compression_argsto add per-compression type defaultarguments which can do things like make the compression more hermetic.
Repro instructions:
Before, the above test would fail with sha256sum mismatches. With this patch, all shasums match.