fix: target_compatible_with excluding arm64 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'ci: update ci and exclude windows' commit added 'target_compatible_with' arguments to some of the tests restricting them to linux but it also forced amd64 instead of allowing the tests to run in both linux/amd64 and linux/arm64. Before this fix, I would get SKIPPED tests when testing on linux/arm64 and now all the tests run.
Just doing 'bazel run' on the locks (except apt_security which is lock-less) and runnign the tests for linux/amd64 and linux/arm64: ``` bazel run @bullseye//:lock bazel run @shared_dependencies//:lock bazel run @noble//:lock bazel test //... ``` produces these changes, which seem to be, mostly, * tabs vs 2 spaces in lock.json * keys with '_' instead of '~' * some tooling in MODULES.lock
thesayyn
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: update ci and exclude windows (#82) added
target_compatible_witharguments to some of the tests restricting them to linux but it also forced amd64 instead of allowing the tests to run in both linux/amd64 and linux/arm64.Before this fix, I would get
SKIPPEDtests when testing on linux/arm64 and now all the tests run.I've also noticed that the locks were not updated and would produce side-effects so I've added a separate
chorecommit to make sure there's "no noise" in the commit and/or when running the tests or other code in the repo.