Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
tejal29 committed Aug 14, 2019
1 parent edf02ff commit 14c87ac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkg/skaffold/kubernetes/portforward/resource_forwarder.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var (
// For testing
retrieveAvailablePort = util.GetAvailablePort
retrieveServices = retrieveServiceResources
kClientSet = kubernetes.GetClientset
getClientSet = kubernetes.GetClientset
)

// NewResourceForwarder returns a struct that tracks and port-forwards pods as they are created and modified
Expand Down Expand Up @@ -104,7 +104,7 @@ func (p *ResourceForwarder) getCurrentEntry(resource latest.PortForwardResource)
// retrieveServiceResources retrieves all services in the cluster matching the given label
// as a list of PortForwardResources
func retrieveServiceResources(label string, namespaces []string) ([]*latest.PortForwardResource, error) {
clientset, err := kClientSet()
clientset, err := getClientSet()
if err != nil {
return nil, errors.Wrap(err, "getting clientset")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ func TestRetrieveServices(t *testing.T) {
objs[i] = s
}
client := fakekubeclientset.NewSimpleClientset(objs...)
t.Override(&kClientSet, mockClient(client))
t.Override(&getClientSet, mockClient(client))
actual, err := retrieveServiceResources(fmt.Sprintf("%s=9876-6789", deploy.RunIDLabel), test.namespaces)
t.CheckNoError(err)
t.CheckDeepEqual(test.expected, actual)
Expand Down

0 comments on commit 14c87ac

Please sign in to comment.