Skip to content

Commit

Permalink
feat: ignore vim *.swp files in hot-reload example (#6895)
Browse files Browse the repository at this point in the history
It is not obvious that `skaffold dev` will rebuild the image
even when a file that is not mapped in `skaffold.yaml`'s
manual sync config is added or changed. `skaffold dev` instead
respects `.dockerignore` as I discovered
[in this issue](#3124).

Add `**/.*.swp` to both node and python directories in the hot-reload
example so that this example is more likely to work out-of-the-box
for new users.

Signed-off-by: David Xia <dxia@spotify.com>
  • Loading branch information
davidxia authored Nov 29, 2021
1 parent 6e95e61 commit 24180d9
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions examples/hot-reload/node/.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# ignore vim swap files
**/.*.swp
2 changes: 2 additions & 0 deletions examples/hot-reload/python/.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# ignore vim swap files
**/.*.swp
2 changes: 2 additions & 0 deletions integration/examples/hot-reload/node/.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# ignore vim swap files
**/.*.swp
2 changes: 2 additions & 0 deletions integration/examples/hot-reload/python/.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# ignore vim swap files
**/.*.swp

0 comments on commit 24180d9

Please sign in to comment.