-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move pollDeploymentStatus to resource.Deployment.CheckStatus
In this PR, - Move pollDeploymentStatus to resource.Deployment.CheckStatus - Add a new interface `Resource` which will be implemented by `Pod` and later. Current it is used for mocking `Deployment` in `pollResourceStatus` test. - Add a concept of retry and non-retry errors.
- Loading branch information
Showing
5 changed files
with
298 additions
and
125 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* | ||
Copyright 2019 The Skaffold Authors | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package deploy | ||
|
||
import ( | ||
"context" | ||
"time" | ||
|
||
"github.com/GoogleContainerTools/skaffold/pkg/skaffold/runner/runcontext" | ||
) | ||
|
||
type Resource interface { | ||
|
||
// UpdateStatus updates the resource status | ||
UpdateStatus(string, error) | ||
|
||
// IsStatusComplete returns if the resource status check is complele | ||
IsStatusComplete() bool | ||
|
||
// Deadline returns the deadline for the resource | ||
Deadline() time.Duration | ||
|
||
// CheckStatus checks resource status | ||
CheckStatus(context.Context, *runcontext.RunContext) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.