Improve error output when kompose fails

Signed-off-by: David Gageot <david@gageot.net>
GoogleContainerTools · Nov 27, 2019 · 4b6d8a0 · 4b6d8a0
1 parent 580a176
commit 4b6d8a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/skaffold/initializer/init.go b/pkg/skaffold/initializer/init.go
@@ -120,8 +120,8 @@ func DoInit(ctx context.Context, out io.Writer, c Config) error {
 		// run kompose first to generate k8s manifests, then run skaffold init
 		logrus.Infof("running 'kompose convert' for file %s", c.ComposeFile)
 		komposeCmd := exec.CommandContext(ctx, "kompose", "convert", "-f", c.ComposeFile)
-		if err := util.RunCmd(komposeCmd); err != nil {
-			return errors.Wrap(err, "running kompose")
+		if _, err := util.RunCmdOut(komposeCmd); err != nil {
+			return err
 		}
 	}
 

diff --git a/pkg/skaffold/util/cmd.go b/pkg/skaffold/util/cmd.go
@@ -74,7 +74,7 @@ func (*Commander) RunCmdOut(cmd *exec.Cmd) ([]byte, error) {
 
 	err = cmd.Wait()
 	if err != nil {
-		return stdout, errors.Wrapf(err, "Running %s: stdout %s, stderr: %s, err: %v", cmd.Args, stdout, stderr, err)
+		return stdout, errors.Wrapf(err, "Running %s\n - stdout: %s\n - stderr: %s", cmd.Args, stdout, stderr)
 	}
 
 	if len(stderr) > 0 {