Skip to content

Commit

Permalink
include explanation for URL pinged
Browse files Browse the repository at this point in the history
  • Loading branch information
MarlonGamez committed Jan 21, 2021
1 parent 4a52cfd commit f88a459
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/skaffold/instrumentation/meter.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ func init() {
doesDeploy.Insert("deploy", "dev", "debug", "run")
}

// SetOnlineStatus issues a GET request to see if the user is online
// SetOnlineStatus issues a GET request to see if the user is online.
// http://clients3.google.com/generate_204 is a well-known URL that returns an empty page and HTTP status 204
// More info can be found here: https://www.chromium.org/chromium-os/chromiumos-design-docs/network-portal-detection
func SetOnlineStatus() {
go func() {
if shouldExportMetrics {
Expand Down

0 comments on commit f88a459

Please sign in to comment.