Skip to content

Commit

Permalink
add back omitted integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
nkubala committed Aug 27, 2021
1 parent 2e6f50f commit fa814e3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
5 changes: 1 addition & 4 deletions integration/diagnose_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,7 @@ func folders(root string) ([]string, error) {
}

for _, f := range files {
// TODO(nkubala): remove once yaml is unhidden
if f.Mode().IsDir() && f.Name() != "docker-deploy" && f.Name() != "react-reload-docker" {
folders = append(folders, f.Name())
}
folders = append(folders, f.Name())
}

return folders, err
Expand Down
1 change: 0 additions & 1 deletion pkg/skaffold/deploy/docker/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ func (d *Deployer) deploy(ctx context.Context, out io.Writer, b graph.Artifact)
Mounts: mounts,
}

// TODO(nkubala)[08/16/21]: events for debugging, port forwarding
id, err := d.client.Run(ctx, out, containerCfg, opts)
if err != nil {
return errors.Wrap(err, "creating container in local docker")
Expand Down

0 comments on commit fa814e3

Please sign in to comment.