Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Dockerfile parsing code #1009

Closed
dgageot opened this issue Sep 21, 2018 · 4 comments
Closed

Cleanup Dockerfile parsing code #1009

dgageot opened this issue Sep 21, 2018 · 4 comments
Assignees
@dgageot
Labels
build/docker

Comments

@dgageot
Copy link
Contributor

dgageot commented Sep 21, 2018

It's currently a big mess!
@r2d4: "they moved all that code to buildkit/dockerfile"
@dgageot dgageot self-assigned this Sep 21, 2018
@r2d4
Copy link
Contributor

r2d4 commented Sep 21, 2018

https://github.com/moby/buildkit/tree/master/frontend/dockerfile should help!

@dgageot
Copy link
Contributor Author

dgageot commented Sep 25, 2018

@r2d4 This is what we are using already, right?

@r2d4
Copy link
Contributor

r2d4 commented Sep 25, 2018

Yes, but I think higher level functions have been created for buildkit, so that we don't have to drop to the shell lexer level

@nkubala
Copy link
Contributor

nkubala commented Nov 29, 2018

To what extent was this addressed by #1053? Can we close this?

@dgageot dgageot closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
build/docker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dgageot @r2d4 @nkubala