Improve Dockerfile parsing #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
==========================================
+ Coverage 40.86% 40.91% +0.05%
==========================================
Files 70 70
Lines 3091 3104 +13
==========================================
+ Hits 1263 1270 +7
- Misses 1703 1706 +3
- Partials 125 128 +3
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
dockerfile-parsing
branch
from
9ea38dc to
f97795d
Compare
balopat
suggested changes
Sep 28, 2018
pkg/skaffold/docker/parse.go
Outdated
| curr.Value = util.Expand(curr.Value, key, value) | ||
| } | ||
| case command.Add, command.Copy: | ||
| files, _ := processCopy(node, envs) |
There was a problem hiding this comment.
we should propagate the error from here IMO, this is where our linter issue can be fixed too.
WDYT?
There was a problem hiding this comment.
yes, I'll handle it
dgageot
force-pushed
the
dockerfile-parsing
branch
2 times, most recently
from
db6c986 to
96a927f
Compare
Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1049 Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1050 Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1052 Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
dockerfile-parsing
branch
from
96a927f to
7cf7a35
Compare
balopat
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1049, #1050 and #1052