Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize/kustomizePath config should be kustomize/path #1032

Closed
dgageot opened this issue Sep 26, 2018 · 1 comment
Closed

kustomize/kustomizePath config should be kustomize/path #1032

dgageot opened this issue Sep 26, 2018 · 1 comment
Assignees
@dgageot
Labels
deploy/kustomize kind/feature-request

Comments

@dgageot
Copy link
Contributor

dgageot commented Sep 26, 2018

Since we are moving to v3 of the configuration file, we should use that opportunity to fix the naming of kustomize/kustomizePath
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 27, 2018
@dgageot
Rename kustomize.KustomizePath to kustomize.Path
ceeb247 
Fixes GoogleContainerTools#1032

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot self-assigned this Sep 27, 2018
@dgageot dgageot mentioned this issue Sep 27, 2018
Merged
@dgageot dgageot reopened this Sep 28, 2018
@dgageot
Copy link
Contributor Author

dgageot commented Sep 28, 2018

This needs to be reverted because it was not merged for 0.15

dgageot added a commit to dgageot/skaffold that referenced this issue Sep 29, 2018
@dgageot
Rename kustomize.KustomizePath to kustomize.Path
d5f7bc3 
Fixes GoogleContainerTools#1032

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot closed this as completed in 0be3f96 Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
deploy/kustomize kind/feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgageot