Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts syntax could look more alike docker-compose syntax #247

Closed
dgageot opened this issue Mar 20, 2018 · 3 comments
Closed

Artifacts syntax could look more alike docker-compose syntax #247

dgageot opened this issue Mar 20, 2018 · 3 comments

Comments

@dgageot
Copy link
Contributor

dgageot commented Mar 20, 2018

Skaffold syntax:

artifacts:
- imageName: domain/image
  workspace: ./src
  dockerfilePath: Dockerfile

Docker-compose syntax for the same thing:

services:
- image: domain/image
  context: ./src
  dockerfile: Dockerfile

By using the same syntax, we'd help some developers learn skaffold quicker.

@r2d4
Copy link
Contributor

r2d4 commented Mar 20, 2018

SGTM. We’ll have to think about “dockerfile” in the future if we want to support different “configs”.

@dgageot
Copy link
Contributor Author

dgageot commented May 28, 2018

I'm going to close this one because it's not really worth the effort

@dgageot dgageot closed this as completed May 28, 2018
@dgageot
Copy link
Contributor Author

dgageot commented Sep 27, 2018

Reopening for v1alpha3

@dgageot dgageot reopened this Sep 27, 2018
@dgageot dgageot self-assigned this Sep 27, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 27, 2018
Fixes GoogleContainerTools#247

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 27, 2018
Fixes GoogleContainerTools#247

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 27, 2018
Fixes GoogleContainerTools#247

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 29, 2018
Fixes GoogleContainerTools#247

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot closed this as completed in ff305af Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants