Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make git tagger the default for both dev and run #425

Closed
r2d4 opened this issue Apr 20, 2018 · 1 comment · Fixed by #476
Closed

Make git tagger the default for both dev and run #425

r2d4 opened this issue Apr 20, 2018 · 1 comment · Fixed by #476
Labels
area/tag

Comments

@r2d4
Copy link
Contributor

r2d4 commented Apr 20, 2018

Right now the default tagger is different for skaffold dev and skaffold run. I think it makes more sense to always tag with git commit, since its more digestible (no pun intended) than a seemingly random checksum.

I've been convinced @dlorenc
@r2d4 r2d4 added the area/tag label Apr 20, 2018
@dgageot
Copy link
Contributor

dgageot commented Apr 22, 2018

@r2d4 Should we create a new version of our config file?

dgageot added a commit to dgageot/skaffold that referenced this issue Apr 26, 2018
@dgageot
Make git tagger the default for both dev and run
d920a60 
Fixes GoogleContainerTools#425

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 27, 2018
@dgageot
Make git tagger the default for both dev and run
c7592d1 
Fixes GoogleContainerTools#425

Signed-off-by: David Gageot <david@gageot.net>
@r2d4 r2d4 mentioned this issue Apr 27, 2018
Merged
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 27, 2018
@dgageot
Make git tagger the default for both dev and run
5ddb371 
Fixes GoogleContainerTools#425

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue May 8, 2018
@dgageot
Make git tagger the default for both dev and run
385cb44 
Fixes GoogleContainerTools#425

Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a Build command dgageot/skaffold
2 participants
@dgageot @r2d4