Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status check - error code Ok when kubernetes cluster's can't be connected. #4672

Closed
tejal29 opened this issue Aug 14, 2020 · 0 comments · Fixed by #4683
Closed

status check - error code Ok when kubernetes cluster's can't be connected. #4672

tejal29 opened this issue Aug 14, 2020 · 0 comments · Fixed by #4683
Assignees
Labels
area/errors area/status-check kind/friction Issues causing user pain that do not have a workaround priority/p0 Highest priority. We are actively looking at delivering it.

Comments

@tejal29
Copy link
Contributor

tejal29 commented Aug 14, 2020

Coming from friction log

When skaffold can't connect to cluster, the error code returned is "STATUSCHECK_SUCCESS".

My gut feeling is, when cluster can't be collected, no pods are retrieved.
https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/deploy/status_check.go#L185

hence status code ok is passed

return proto.StatusCode_STATUSCHECK_SUCCESS

This should be a simple change to return the deployment error code if len (d.pods) is 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/errors area/status-check kind/friction Issues causing user pain that do not have a workaround priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants