status check - error code Ok when kubernetes cluster's can't be connected. #4672
Labels
area/errors
area/status-check
kind/friction
Issues causing user pain that do not have a workaround
priority/p0
Highest priority. We are actively looking at delivering it.
Milestone
Coming from friction log
When skaffold can't connect to cluster, the error code returned is "STATUSCHECK_SUCCESS".
My gut feeling is, when cluster can't be collected, no pods are retrieved.
https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/deploy/status_check.go#L185
hence status code ok is passed
skaffold/pkg/skaffold/deploy/resource/deployment.go
Line 276 in 6994b45
This should be a simple change to return the deployment error code if len (d.pods) is 0.
The text was updated successfully, but these errors were encountered: