Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providing a url to -f flag doesn't work with remote configs #5404

Closed
gsquared94 opened this issue Feb 17, 2021 · 0 comments · Fixed by #5405
Closed

Providing a url to -f flag doesn't work with remote configs #5404

gsquared94 opened this issue Feb 17, 2021 · 0 comments · Fixed by #5405
Assignees
@gsquared94
Labels
area/modules kind/bug Something isn't working priority/p1 High impact feature/bug.
Milestone
v1.21.0

Comments

@gsquared94
Copy link
Contributor

Expected behavior

Run:

skaffold run -f https://raw.githubusercontent.com/gsquared94/skaffold-remote-configs-demo/main/skaffold.yaml

Skaffold uses the url provided as the main config and downloads any remote configs specified in that file.

Actual behavior

Skaffold fails with the error:

parsing skaffold config: could not find skaffold config /Users/gaghosh/https:/raw.githubusercontent.com/gsquared94/skaffold-remote-configs-demo/main/skaffold.yaml that is referenced as a dependency in config /Users/gaghosh/https:/raw.githubusercontent.com/gsquared94/skaffold-remote-configs-demo/main/skaffold.yaml

Information
@gsquared94 gsquared94 self-assigned this Feb 17, 2021
@gsquared94 gsquared94 added kind/bug Something isn't working priority/p1 High impact feature/bug. area/modules labels Feb 17, 2021
gsquared94 added a commit to gsquared94/skaffold that referenced this issue Feb 17, 2021
@gsquared94
fix: GoogleContainerTools#5404
7f7011c
@gsquared94 gsquared94 mentioned this issue Feb 17, 2021
Merged
@gsquared94 gsquared94 added this to the v1.21.0-rc milestone Feb 18, 2021
gsquared94 added a commit that referenced this issue Feb 19, 2021
@gsquared94
Fixes #5404: Skaffold configs downloaded from a url can define remote…
5701c38 
… config dependencies (#5405)

* fix: #5404

* simplify duplicate configs check

* fix error unwrap

* add comment about calculating `isDependency`

* fix UT

* simplify test and add TODO

* fix linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsquared94 gsquared94

Labels
area/modules kind/bug Something isn't working priority/p1 High impact feature/bug.
Projects
None yet
Milestone
v1.21.0
1 participant
@gsquared94