Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold apply does not support --rpc-port (and similar flags atm) #7756

Closed
aaron-prindle opened this issue Aug 8, 2022 · 4 comments · Fixed by #7799
Closed

skaffold apply does not support --rpc-port (and similar flags atm) #7756

aaron-prindle opened this issue Aug 8, 2022 · 4 comments · Fixed by #7799
Assignees
Labels
help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/todo implementation task/epic for the skaffold team priority/p2 May take a couple of releases source/partnerships
Milestone

Comments

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Aug 8, 2022

Currently --enable-rpc is deprecated atm and skaffold apply does not support --rpc-port meaning there is no acceptable way atm to setup the skaffold-server/watch-events with skaffold apply. We should add apply to the list of commands which take the --rpc-port flag and similar flags (--rpc-http-port, etc.) and plumb them through so that when we eventually fully deprecate --enable-rpc there will not be any breaking workflows

@aaron-prindle aaron-prindle added the priority/p2 May take a couple of releases label Aug 8, 2022
@aaron-prindle aaron-prindle added this to the 2.0.0-beta2 milestone Aug 8, 2022
@aaron-prindle aaron-prindle self-assigned this Aug 8, 2022
@tejal29 tejal29 added the kind/todo implementation task/epic for the skaffold team label Aug 8, 2022
@tejal29
Copy link
Contributor

tejal29 commented Aug 15, 2022

@OladapoAjala would you be interested in working on this?

@aaron-prindle aaron-prindle removed their assignment Aug 15, 2022
@aaron-prindle
Copy link
Contributor Author

aaron-prindle commented Aug 15, 2022

Awesome! We can assign this issue to you then @OladapoAjala. Seems I am not able to assign this using the Github UI currently though, perhaps when your other PR is merged then you will be available to be assigned via the UI.

@aaron-prindle aaron-prindle added help wanted We would love to have this done, but don't have the bandwidth, need help from contributors source/partnerships labels Aug 15, 2022
@OladapoAjala
Copy link
Contributor

@aaron-prindle you can assign this now that I have commented on it.

@aaron-prindle
Copy link
Contributor Author

aaron-prindle commented Aug 23, 2022

Great, I've assigned this now. For more context here, currently skaffold apply supports the --enable-rpc flag which is deprecated but not the newer --rpc-port flag:
https://github.com/GoogleContainerTools/skaffold/blob/main/cmd/skaffold/app/cmd/flags.go#L210-L217
Name: "rpc-port",
...
DefinedOn: []string{"dev", "build", "run", "debug", "deploy", "test", "verify"}, // <--- no "apply" currently, needs to be added

I believe you will need to add apply to the DefinedOn values and possibly do additional plumbing but I think that might actually be it IIUC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/todo implementation task/epic for the skaffold team priority/p2 May take a couple of releases source/partnerships
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants