Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added apply to --rpc-port and --rpc-http-port definedons #7799

Merged

Conversation

OladapoAjala
Copy link
Contributor

Fixes: #7756

Description
Added --rpc-port and --rpc-http-port flags to skaffold apply

@OladapoAjala OladapoAjala force-pushed the add-rpc-ports-to-skaffold-apply branch from e172bad to 04fd205 Compare August 23, 2022 21:47
@aaron-prindle
Copy link
Contributor

aaron-prindle commented Aug 23, 2022

Great thanks for this!! Just tested this locally seems everything is working properly for apply with --rpc-port and --rpc-http-port definitions. With this we can finally move to removing --enable-rpc when we hit the timeline to do so 🎊

@aaron-prindle aaron-prindle marked this pull request as ready for review August 23, 2022 21:51
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle
Copy link
Contributor

Tests are failing because you also need to run ./hack/generate-man.sh to update our CLI docs to include this flag.
After that all tests should pass

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #7799 (5c7b080) into main (290280e) will decrease coverage by 3.91%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7799      +/-   ##
==========================================
- Coverage   70.48%   66.56%   -3.92%     
==========================================
  Files         515      592      +77     
  Lines       23150    28591    +5441     
==========================================
+ Hits        16317    19032    +2715     
- Misses       5776     8159    +2383     
- Partials     1057     1400     +343     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 363 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tejal29 tejal29 merged commit 3f0475f into GoogleContainerTools:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold apply does not support --rpc-port (and similar flags atm)
3 participants