Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any network to be provided to docker builder #9389

Closed
edwardthiele opened this issue Apr 16, 2024 · 1 comment · Fixed by #9390
Closed

Allow any network to be provided to docker builder #9389

edwardthiele opened this issue Apr 16, 2024 · 1 comment · Fixed by #9390

Comments

@edwardthiele
Copy link

Under the Skaffold build configuration for docker, you can provide a network to connect the docker container (https://skaffold.dev/docs/references/yaml/#build-artifacts-docker-network), however you are restricted in terms of what network options can be set.

In particular, you cannot set network=cloudbuild, which can be helpful for auth reasons when running inside Google Cloud Build.

Expected behavior

You should be able to set network=cloudbuild and ideally any other network

Actual behavior

Validation fails when network=cloudbuild is set

@idsulik
Copy link
Contributor

idsulik commented Apr 17, 2024

Removed validation within this PR #9390, now it supports any network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants