feat(docker-network): docker.network now supports any value #9390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idsulik
commented
Apr 17, 2024
| @@ -1,3 +1,5 @@ | |||
| module github.com/hashicorp/hcl | |||
|
|
|||
| go 1.22 | |||
There was a problem hiding this comment.
to fix this issue #9352 (comment)
|
Hi @idsulik , thank you for the pr, I think we might not need a new schema version. |
|
@ericzzzzzzz , agree. replaced the commit(it was easy to replace rather than update the current) |
ericzzzzzzz
approved these changes
Apr 17, 2024
|
@ericzzzzzzz hi! When the release is scheduled? |
|
Hi, @idsulik We haven't set a specific release date yet, but we expect it to be available sometime next month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9389
Description
Removed docker network validation, now you can pass any network
User facing changes (remove if N/A)
before: docker.network used to support only predefined values.
before: docker.network supports any value.