-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updating google api and opentelemetry version #9352
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9352 +/- ##
==========================================
- Coverage 70.48% 63.58% -6.91%
==========================================
Files 515 635 +120
Lines 23150 32790 +9640
==========================================
+ Hits 16317 20848 +4531
- Misses 5776 10334 +4558
- Partials 1057 1608 +551 ☔ View full report in Codecov by Sentry. |
@bskaplan hi! why you added |
I didn't have any particular reason. I was updating the dependent modules, I guess that file got picked up when I updated them and I was mostly focused on making sure everything still worked with the updates. If that file isn't necessary, you can send another PR deleting it. |
@bskaplan have you deleted the line by yourself? because golang adds this line by itself whenever you use any go command. |
Hi @idsulik, I think we may have to keep this file. The file was auto-generated by |
@ericzzzzzzz Thank you for the details, added the go version here https://github.com/GoogleContainerTools/skaffold/pull/9390/files#diff-8939f41b03be02a3877b5d557f6b6adb21c33906b5c3093f6e7f626ed9f07044R3 , otherwise go cli updates it automatically and you see changed file, so you have to manually exclude it from commit |
Description
Update the Google Cloud API Client and OpenTelemetry to the latest versions.
User facing changes (remove if N/A)
The latest Cloud Run features will now be supported, notably built-in support for mounting gcsfuse and NFS volumes. See https://cloud.google.com/run/docs/configuring/services/cloud-storage-volume-mounts#yaml and https://cloud.google.com/run/docs/configuring/services/nfs-volume-mounts#yaml for example YAMLs.